Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Provide a Bracket Highlighter matching color scheme #905

Closed
txemaleon opened this issue Jul 16, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@txemaleon
Copy link

txemaleon commented Jul 16, 2016

I've started using Bracket Higlighter which provides better bracket matching visuals for Sublime Text.

This plugin is often referred as one of essentials sublime text plugins for web developers and has over 1M installs in Package Control.

Right now all bracket types are painted in white. It would be really nice to pack Material Theme with colors for this package.

Looks like it can be done this way inside the theme:

<!-- BEGIN Bracket Highlighter plugin color modifications -->

<dict>
    <key>name</key>
    <string>Unmatched</string>
    <key>scope</key>
    <string>brackethighlighter.unmatched</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#FD971F</string>
    </dict>
</dict>

<dict>
    <key>name</key>
    <string>Bracket Curly</string>
    <key>scope</key>
    <string>brackethighlighter.curly</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#FF0000</string>
    </dict>
</dict>

<dict>
    <key>name</key>
    <string>Bracket Round</string>
    <key>scope</key>
    <string>brackethighlighter.round</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#0000FF</string>
    </dict>
</dict>

And in Brackets Highlighter preferences it defines the following ids:

  • brackethighlighter.default
  • brackethighlighter.unmatched
  • brackethighlighter.curly
  • brackethighlighter.round
  • brackethighlighter.square
  • brackethighlighter.angle
  • brackethighlighter.tag
  • brackethighlighter.c_define
  • brackethighlighter.quote
@equinusocio
Copy link
Member

equinusocio commented Jul 18, 2016

I will add only brackethighlighter.default = paleblue and the brackethighlighter.unmatched = red. So the default brackets color is the paleblue and not a set of different color.

Please note that this package collide with GutterColor package. @txemaleon Plese next time use the issue template. I will close any issue that does not follow the template 👍

@equinusocio equinusocio added this to the v3.1.0 milestone Jul 18, 2016
@equinusocio equinusocio self-assigned this Jul 18, 2016
equinusocio added a commit that referenced this issue Jul 27, 2016
commit ce8ee2a
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Wed Jul 27 11:38:52 2016 +0200

    chore: fix changelog

commit 35ff8f0
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Tue Jul 26 20:59:36 2016 +0200

    chore: update CHANGELOG.md

commit ba27326
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Tue Jul 26 20:59:25 2016 +0200

    release 3.0.3

commit c73bed2
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Tue Jul 26 20:57:36 2016 +0200

    chore: bump version number

commit 91e1ce5
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Tue Jul 26 20:39:52 2016 +0200

    chore: Update R fixtures and icons

commit 89ed8d6
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Tue Jul 26 20:32:25 2016 +0200

    chore: improve project structure

commit 5152366
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Tue Jul 26 20:22:58 2016 +0200

    feat: Add linter gutter theme

commit 47af504
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Mon Jul 18 11:30:42 2016 +0200

    feat: Add BracketHighlighter support

    Close #905

commit 7def21a
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Mon Jul 11 09:20:53 2016 +0200

    Add es-lint linter

commit c47039f
Author: mattia.astorino <astorino.design@gmail.com>
Date:   Fri Jul 8 09:32:33 2016 +0200

    chore: add jshint config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants