Add function for converting strings in snake_case to CamelCase #23
Conversation
| 'snake', | ||
| 'snake', | ||
| false, | ||
| ] |
There was a problem hiding this comment.
I noticed you had some special handling for extra underscores - it might be good to see some tests of that.
|
(@shadowhand presumably has a fix in the works for the Travis failures, by the way.) |
| */ | ||
| function snakeToCamelCase($snake_string, $first = false) | ||
| { | ||
| $camel = implode('', array_map(function($piece) { |
There was a problem hiding this comment.
This can be a static function as a micro optimization.
|
I remember seeing those errors with Travis before, but I am not sure what they are caused by. |
|
@bvisness I need the function for use in
|
|
I say go for it. (Once the Travis issues are resolved, anyway... @shadowhand, perhaps it is an old version of PHPUnit again?) |
|
@bvisness this build had no issues: https://travis-ci.org/equip/assist/jobs/155386468 |
| function snakeToCamelCase($snake_string, $first = false) | ||
| { | ||
| $camel = implode('', array_map(static function($piece) { | ||
| return empty($piece) ? '' : ucfirst(strtolower($piece)); |
There was a problem hiding this comment.
Using array_filter would remove the need for this ternary.
| { | ||
| $camel = implode('', array_map(static function($piece) { | ||
| return empty($piece) ? '' : ucfirst(strtolower($piece)); | ||
| }, explode('_', $snake_string))); |
There was a problem hiding this comment.
Replacing this explode with preg_split('/_++/', $snake_string) would also remove the need for the ternary, as empty values would be impossible.
The most recent version of lstrojny/functional-php (1.4) is incompatible with HHVM so we much lock the version's upper bound in order for equip/assist to continue to work on HHVM.
sctape
force-pushed
the
feature/camel-case-converter
branch
from
f4a41a6
to
b8651d8
Compare
|
@shadowhand @bvisness Looks like |
|
👍 |
No description provided.