Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Improve regression testing framework #207

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

leroyvn
Copy link
Member

@leroyvn leroyvn commented Apr 14, 2022

Description

This commit improves the regression testing framework with the following changes:

  • Artefact names are now assembled from a test name and an archive directory, both set in the test code.
  • The reference data can now be passed as a data store path.
  • Spectral results (e.g. with more than a single CKD bin) are now handled.
  • Various type hint and docstring fixes.

This overall simplifies the test code and improves its robustness by handling cases where the reference is expected to be retrieved from the data store but is still missing (relevant when adding a new regression test case).

To do

  • Update testing framework tests
  • Update change log

Checklist

  • The code follows the relevant coding guidelines
  • The code generates no new warnings
  • The code is appropriately documented
  • The code is tested to prove its function
  • The feature branch is rebased on the current state of the main branch
  • I give permission that the Eradiate project may redistribute my contributions under the terms of its license

@leroyvn leroyvn added enhancement 🦾 New feature or request ⚗️ testing This issue has to do with testing labels Apr 14, 2022
@leroyvn leroyvn requested a review from schunkes April 14, 2022 13:32
@leroyvn leroyvn marked this pull request as draft April 14, 2022 13:34
@leroyvn leroyvn marked this pull request as ready for review April 14, 2022 13:43
@schunkes
Copy link
Member

Looks good :)

This commit improves the regression testing framework with the following
changes:

* Artefact names are now assembled from a test name and an archive
  directory, both set in the test code.

* The reference data can now be passed as a data store path.

* Spectral results (e.g. with more than a single CKD bin) are now handled.

* Various type hint and docstring fixes.

This overall simplifies the test code and improves its robustness by
handling cases where the reference is expected to be retrieved from the
data store but is still missing (relevant when adding a new regression
test case).
@leroyvn leroyvn merged commit 3b94f19 into main Apr 14, 2022
@leroyvn leroyvn deleted the improve_regression branch April 14, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🦾 New feature or request ⚗️ testing This issue has to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants