Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSDF plugins in CentralPatchSurface were in the wrong order #237

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

schunkes
Copy link
Member

Description

The blendbsdf plugin in mitsuba sorts the nested BSDFs alphanumerically by their identifier. That means, that the previous names for the two BSDFs in the CentralPatchSurface would put them in the wrong order. The updated naming solves that issue.

Checklist

  • The code follows the relevant coding guidelines
  • The code generates no new warnings
  • The code is appropriately documented
  • The code is tested to prove its function
  • The feature branch is rebased on the current state of the main branch
  • I updated the change log if relevant
  • I give permission that the Eradiate project may redistribute my contributions under the terms of its license

@schunkes schunkes merged commit 7b67f13 into main Jun 10, 2022
@schunkes schunkes deleted the blend_bugfix branch June 10, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant