Don't render cards in notifications unless they are mentions/replies

Fixes #577
eramdam · Apr 9, 2021 · f7e4151 · f7e4151
1 parent e8d41a7
commit f7e4151
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/features/renderCardsInColumns.ts b/src/features/renderCardsInColumns.ts
@@ -8,6 +8,7 @@ import {
   TweetDeckChirp,
   TweetDeckColumn,
   TweetDeckColumnMediaPreviewSizesEnum,
+  TwitterActionEnum,
 } from '../types/tweetdeckTypes';
 
 export const maybeRenderCardsInColumns = makeBTDModule((options) => {
@@ -108,7 +109,11 @@ export const maybeRenderCardsInColumns = makeBTDModule((options) => {
     const baseChirp = getChirpFromKey(TD, payload.chirp.id, payload.columnKey);
 
     // In the case of a reply, we want the `targetTweet`, as the chirp itself is just a notification
-    const actualChirp = baseChirp?.targetTweet ? baseChirp.targetTweet : baseChirp;
+    const isEligibleNotification =
+      payload.chirpExtra.action === TwitterActionEnum.MENTION ||
+      payload.chirpExtra.action === TwitterActionEnum.REPLY;
+    const actualChirp =
+      baseChirp?.targetTweet && isEligibleNotification ? baseChirp.targetTweet : baseChirp;
 
     if (!actualChirp || !actualChirp.card || !renderCardForChirpModule || !getColumnTypeModule) {
       return;