Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undocumented daemon JSON RPC methods #27

Open
wants to merge 2 commits into
base: up-rpc
Choose a base branch
from

Conversation

benevanoff
Copy link

Should be the rest of the missing RPC methods up to v0.17.3 including RPC-Pay methods

erciccione and others added 2 commits November 10, 2021 09:08
Co-authored-by: benevanoff <benjaminevanoff99@gmail.com>
Co-authored-by: Nathan Dorfman <ndorf@rtfm.net>
@erciccione
Copy link
Owner

Awesome. Thanks @benevanoff. I asked for reviewers in monero-dev, but no luck yet. Trying pinging people directly.

@moneromooo-monero @selsta could you review this PR or ping somebody who is willing to?

@@ -1427,6 +1441,231 @@ $ curl http://127.0.0.1:18081/json_rpc -d '{"jsonrpc":"2.0","id":"0","method":"g
```


### **get_miner_data**

Fetch data about miner running from monerod.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better description: Fetch data required to create a custom block template.

Outputs:

* *hashing_blob* - string; A block template for the next block with the reward pointing toward the node operator, serialized to a hex string.
* *seed_height* - usigned int; The height of the block to use as seed in Random-X proof-of-work.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little off-topic nitpic: It's RandomX, without minus sign.

* *seed_hash* - string (32 byte hex); The id of the block to use as seed in Random-X proof-of-work.
* *next_seed_hash* - string (32 byte hex); The id of the next block to use as seed in Random-X proof-of-work.
* *cookie* - usigned int; The identifier cookie to keep track of the client.
* *diff* unsigned int; The current network difficulty.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite in general I ask myself whether it would be worth for this RPC documentation to not simply give unsigned int, but also the width, i.e. 32 for cookie but 64 for diff, but this probably goes beyond this PR.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i would keep that outside this PR for now.

Copy link

@rbrunner7 rbrunner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I checked against the current masterbranch version of file src/rpc/core_rpc_server_commands_defs.h and could not find any mistakes like missing parameters or typos in parameter names.

@erciccione
Copy link
Owner

ping @benevanoff

(upstream PR: monero-project#1448)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants