Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon-rpc: update output of all calls and their description #1448

Merged
merged 1 commit into from Dec 22, 2021
Merged

daemon-rpc: update output of all calls and their description #1448

merged 1 commit into from Dec 22, 2021

Conversation

erciccione
Copy link
Contributor

@erciccione erciccione commented Feb 2, 2021 •
edited

I tested all the current calls and updated their description in our RPC guide for the daemon.

This is still a work in progress, i tested all the calls but many definitions need to be updated. Any help would be highly appreciated.

grep TODO to find the definitions that still need to be updated.

part of #1434

@netlify
Copy link

netlify bot commented Feb 2, 2021 •
edited

✔️ Deploy Preview for barolo-time-757cf9 ready!

🔨 Explore the source changes: adb4c2e

🔍 Inspect the deploy log: https://app.netlify.com/sites/barolo-time-757cf9/deploys/61c303e0cd0a7c0007c689cc

😎 Browse the preview: https://deploy-preview-1448--barolo-time-757cf9.netlify.app

moneromooo-monero
moneromooo-monero reviewed Feb 2, 2021
View reviewed changes
resources/developer-guides/daemon-rpc.md Outdated Show resolved Hide resolved
resources/developer-guides/daemon-rpc.md Outdated Show resolved Hide resolved
resources/developer-guides/daemon-rpc.md

### **flush_txpool**

Flush tx ids from transaction pool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one removed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gave me an error when trying to call it, but i guess that could be intended. Reverting

@moneromooo-monero
Copy link
Contributor

The vast majority of addition are just "TODO", wrong patch uploaded ?

@erciccione
Copy link
Contributor Author

erciccione commented Feb 2, 2021 •
edited

The vast majority of addition are just "TODO", wrong patch uploaded ?

Sorry i wasn't clear. Most of the TODOs are new responses (like difficulty_top64, next_seed_hash, seed_hash, seed_height, etc) that don't have a definition yet. I left them as TODOs hoping to get the correct definitions from CLI devs.

Thanks for the other suggestions, i will implement them with the next pushes.

@erciccione
Copy link
Contributor Author

erciccione commented Feb 3, 2021 •
edited

So, as i mentioned in my precedent comment, some new definitions were added and need to be described. This is the list of the responses that still need a description (grep TODO to find them in this PR):

difficulty_top64
next_seed_hash
seed_hash
seed_height
wide_difficulty
wide_cumulative_difficulty
wide_fee_amount
wide_emission_amount
block_weight
block_weight_limit
block_weight_median
cumulative_difficulty_top64
long_term_weight
credits
long_term_weight
miner_tx_hash
pow_hash
database_size
nettype
update_available
version (get_info)
emission_amount_top64
fee_amount_top64
release
main_chain_parent_block
next_needed_pruning_seed
overview
prunable_as_hex
prunable_hash
pruned_as_hex
bg_idle_threshold
bg_ignore_battery
bg_min_idle_seconds
bg_target
block_reward
block_target
pow_algorithm
fee_total

@erciccione erciccione mentioned this pull request Feb 4, 2021
Closed
@erciccione erciccione mentioned this pull request Apr 4, 2021
Merged
@erciccione
Copy link
Contributor Author

More definitions added. Thanks @ndorf.

@carrington1859 carrington1859 mentioned this pull request Nov 4, 2021
Open
@erciccione
Copy link
Contributor Author

Some missing calls are being added to this pr with erciccione#26. We need that PR to be checked by somebody familiar with the daemon before merging it.

@erciccione erciccione marked this pull request as ready for review November 10, 2021 09:11
@erciccione erciccione moved this from Draft to Review Needed in monero-site: PR workflow Nov 10, 2021
@erciccione
Copy link
Contributor Author

This is ready to be reviewed.

@erciccione erciccione mentioned this pull request Dec 8, 2021
Open
moneromooo-monero
moneromooo-monero reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@moneromooo-monero moneromooo-monero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few really minor nits, but it's good to go either way

resources/developer-guides/daemon-rpc.md Outdated Show resolved Hide resolved
resources/developer-guides/daemon-rpc.md Outdated Show resolved Hide resolved
resources/developer-guides/daemon-rpc.md Outdated Show resolved Hide resolved
@erciccione @benevanoff @ndorf
daemon-rpc: update calls and their descriptions
adb4c2e 
Co-authored-by: benevanoff <benjaminevanoff99@gmail.com>
Co-authored-by: Nathan Dorfman <ndorf@rtfm.net>
@erciccione erciccione moved this from Review Needed to Ready for merge in monero-site: PR workflow Dec 22, 2021
@luigi1111 luigi1111 merged commit b0475a8 into monero-project:master Dec 22, 2021
monero-site: PR workflow automation moved this from Ready for merge to Done Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moneromooo-monero moneromooo-monero moneromooo-monero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
monero-site: PR workflow
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erciccione @moneromooo-monero @luigi1111