This repository has been archived by the owner on May 30, 2020. It is now read-only.
Added submessage parsing for LRespones #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which will be parsed and used by cube.py
-repaired tests (unfortnately not all...) -added a better message check in lresponse, a submessage needs to be at least 6 bytes long (everything shorter isn't a valid message)
3 similar comments
|
Thank you very much for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
my python skills aren't that great, but it seems to work. Now there should be submessage parsing for LResponses. But it comes at a small price, I introduced a new class "SingleLResponse" which will contain all the different settings. Also I enhanced the "str" function. Now you can easily see all fields.
Another thing I introduced is a LMessage, to ask the cube for an device_list update (via cube.get_device_list())
Best regards
PS.: I like your project and thanks for the work!