Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: workBench to dop #392

Merged
merged 8 commits into from
Jun 24, 2021

Conversation

laojun
Copy link
Contributor

@laojun laojun commented Jun 23, 2021

What type of PR is this?

  • Feature
  • Bugfix
  • Test
  • Documentation
  • Refactor
  • Style
  • Chore

What this PR does / why we need it:

refactor: workBench to dop

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user interface change?

  • Yes(screenshot is required)
  • No

Special notes for your reviewer:

@laojun laojun added the refactor Refactor label Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #392 (b5d8532) into master (07129b5) will increase coverage by 5.34%.
The diff coverage is 38.11%.

❗ Current head b5d8532 differs from pull request most recent head 2886d10. Consider uploading reports for the commit 2886d10 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   59.42%   64.77%   +5.34%     
==========================================
  Files         113      115       +2     
  Lines        6445     6637     +192     
  Branches     1762     1681      -81     
==========================================
+ Hits         3830     4299     +469     
+ Misses       2596     2313     -283     
- Partials       19       25       +6     
Impacted Files Coverage Δ
shell/app/common/components/addon-resource.jsx 100.00% <ø> (ø)
...l/app/common/components/authorize-member-modal.tsx 34.09% <0.00%> (ø)
shell/app/common/components/contractive-filter.tsx 5.72% <0.00%> (ø)
shell/app/common/components/copy.tsx 77.50% <0.00%> (ø)
shell/app/common/components/load-more-selector.tsx 8.45% <ø> (ø)
shell/app/common/components/member-selector.tsx 15.58% <0.00%> (ø)
shell/app/common/components/members-table.tsx 13.74% <0.00%> (-0.14%) ⬇️
shell/app/common/utils/axios-config.ts 0.00% <0.00%> (ø)
shell/app/common/utils/api-creator.ts 12.76% <12.76%> (ø)
shell/app/common/utils/index.ts 61.42% <14.28%> (-12.94%) ⬇️
... and 21 more

@daskyrk
Copy link
Contributor

daskyrk commented Jun 24, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Jun 24, 2021
@erda-bot erda-bot merged commit 0e3702c into erda-project:master Jun 24, 2021
@laojun laojun deleted the feature/zxj-workbench-to-dop branch July 6, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot refactor Refactor
Development

Successfully merging this pull request may close these issues.

3 participants