move scene check cycle #2309
Merged
move scene check cycle #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he reference is circular
Codecov Report
@@ Coverage Diff @@
## master #2309 +/- ##
==========================================
- Coverage 15.94% 15.84% -0.10%
==========================================
Files 1182 1192 +10
Lines 116929 117717 +788
==========================================
+ Hits 18641 18655 +14
- Misses 96362 97148 +786
+ Partials 1926 1914 -12
|
sfwn
approved these changes
Oct 11, 2021
|
/approve |
erda-bot
approved these changes
Oct 11, 2021
|
/cherry-pick release/1.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 11, 2021
* Automatic test configuration doc output reference (erda-project#2195) * When the scene refers to the scene set, add the judgment of whether the reference is circular
erda-bot
added a commit
that referenced
this pull request
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
bug
What this PR does / why we need it:
When the application type scene is moved, it is not checked whether there is a cyclic application. If the cyclic dependency is not detected, it will cause an infinite loop during execution.
Test case: