Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2309: move scene check cycle #2315

Conversation

erda-bot
Copy link
Member

Cherry pick of #2309 on release/1.3.

Squashed commit message:

commit 00201aa0e8482bdecdd8fa1b12bc9dfbd54fdb45
Author: kakj <18579115540@163.com>
Date:   Mon Oct 11 19:34:53 2021 +0800

    move scene check cycle (#2309)
    
    * Automatic test configuration doc output reference (#2195)
    
    * When the scene refers to the scene set, add the judgment of whether the reference is circular

What type of this PR

bug

What this PR does / why we need it:

When the application type scene is moved, it is not checked whether there is a cyclic application. If the cyclic dependency is not detected, it will cause an infinite loop during execution.

Test case:

image

* Automatic test configuration doc output reference (erda-project#2195)

* When the scene refers to the scene set, add the judgment of whether the reference is circular
@sfwn
Copy link
Member

sfwn commented Oct 11, 2021

/approve

@erda-bot erda-bot merged commit fd12aeb into erda-project:release/1.3 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants