Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: eventbox support custom notify channel #2460

Merged

Conversation

snakorse
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

feature: eventbox support custom notify channel

Specified Reviewers:

/assign @liuhaoyang @innerpeacez

ChangeLog

Language Changelog
🇺🇸 English Support send sms alert via custom notify channel
🇨🇳 中文 支持使用自定义通知渠道发送告警短信

@snakorse snakorse added msp microsevice platform feature labels Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #2460 (ebac4a8) into master (c81d8f5) will increase coverage by 0.84%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2460      +/-   ##
==========================================
+ Coverage   15.91%   16.76%   +0.84%     
==========================================
  Files        1218     1261      +43     
  Lines      123507   128242    +4735     
==========================================
+ Hits        19656    21496    +1840     
- Misses     101827   104536    +2709     
- Partials     2024     2210     +186     
Impacted Files Coverage Δ
modules/pkg/etcdclient/etcdclient.go 39.53% <57.14%> (+39.53%) ⬆️
...odules/core/monitor/log/query/log.query.service.go 15.05% <0.00%> (-45.82%) ⬇️
modules/core/monitor/log/query/routes.go 12.16% <0.00%> (-42.13%) ⬇️
modules/cmp/component-protocol/cputil/util.go 21.52% <0.00%> (-26.01%) ⬇️
modules/cmp/cache/cache.go 50.86% <0.00%> (-13.70%) ⬇️
modules/core/monitor/log/query/provider.go 15.38% <0.00%> (-3.37%) ⬇️
...p-dashboard-workloads-list/workloadTable/render.go 55.32% <0.00%> (-3.28%) ⬇️
modules/core/monitor/collector/provider.go 7.69% <0.00%> (-1.84%) ⬇️
modules/admin/manager/cluster.go 12.34% <0.00%> (-1.17%) ⬇️
...s/cmp-dashboard-podDetail/containerTable/render.go 4.97% <0.00%> (-0.91%) ⬇️
... and 151 more

@liuhaoyang liuhaoyang merged commit c68f7cd into erda-project:master Nov 1, 2021
@liuhaoyang
Copy link
Contributor

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 1, 2021
* feature: eventbox support custom notify channel

* bugfix: change notify channel response struct

* optimize: add unit test.

* optimize: change channel provider name.

* optimize: unit test naming

* optimize: add etcd cert file env

* optimize: add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature msp microsevice platform
Development

Successfully merging this pull request may close these issues.

None yet

2 participants