Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-import judge data length about estimate time and close time #3136

Conversation

chengjoey
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind bugfix

What this PR does / why we need it:

issue-import judge data length about estimate time and close time

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English Fix the bug that import issue status code 502 in dopplatform
🇨🇳 中文 修复了导入事项502的问题

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey added bugfix dop devops plaoform labels Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #3136 (00e58d1) into master (4428044) will increase coverage by 0.02%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3136      +/-   ##
==========================================
+ Coverage   17.45%   17.48%   +0.02%     
==========================================
  Files        1369     1369              
  Lines      140799   140808       +9     
==========================================
+ Hits        24582    24624      +42     
+ Misses     113673   113630      -43     
- Partials     2544     2554      +10     
Impacted Files Coverage Δ
modules/dop/services/issue/convert.go 56.44% <69.23%> (+9.32%) ⬆️
.../components/cmp-dashboard-nodes/cpuTable/render.go 19.23% <0.00%> (+0.36%) ⬆️
...mponents/cmp-dashboard-nodes/common/table/table.go 16.42% <0.00%> (+0.79%) ⬆️
.../components/cmp-dashboard-nodes/memTable/render.go 23.76% <0.00%> (+4.15%) ⬆️

@chengjoey chengjoey force-pushed the fix/issue-import-compatible-old-version branch 2 times, most recently from 737fd21 to 5722383 Compare November 23, 2021 08:32
@chengjoey chengjoey force-pushed the fix/issue-import-compatible-old-version branch from 5722383 to 00e58d1 Compare November 23, 2021 09:48
@sfwn
Copy link
Member

sfwn commented Nov 24, 2021

/approve

@erda-bot erda-bot merged commit 45cc67f into erda-project:master Nov 24, 2021
@chengjoey chengjoey deleted the fix/issue-import-compatible-old-version branch April 18, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants