feat: Standard issue filter provider, add issue complexity and states #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3469 +/- ##
==========================================
- Coverage 18.40% 18.37% -0.04%
==========================================
Files 1437 1437
Lines 149001 149075 +74
==========================================
- Hits 27425 27392 -33
- Misses 118759 118914 +155
+ Partials 2817 2769 -48
|
shuofan
force-pushed
the
feature/issue-manage-filter
branch
from
6307350
to
8b92d7c
Compare
shuofan
changed the title
sfwn
requested changes
Dec 31, 2021
| InitProviderWithNameSpace(MakeComponentProviderName(scenario, compName), creator) | ||
| } | ||
|
|
||
| func InitProviderWithNameSpace(providerName string, creator servicehub.Creator) { |
There was a problem hiding this comment.
Do not expose this method, rename to initProviderWithCustomName.
Add a new methods InitProviderToDefaultNamespace for default comp register.
| } | ||
|
|
||
| func init() { | ||
| base.InitProviderWithCreator("issue-kanban", "issueFilter", func() servicehub.Provider { | ||
| base.InitProviderWithNameSpace("component-protocol.default-components.issueFilter", func() servicehub.Provider { |
There was a problem hiding this comment.
use InitProviderToDefaultNamespace
| @@ -33,6 +34,13 @@ func MustGetScenarioAndCompNameFromProviderKey(providerKey string) (scenario, co | |||
| } | |||
|
|
|||
| func GetScenarioAndCompNameFromProviderKey(providerKey string) (scenario, compName, instanceName string, err error) { | |||
| if strings.HasPrefix(providerKey, defaultComponentProviderNamePrefix) { | |||
shuofan
force-pushed
the
feature/issue-manage-filter
branch
from
8b92d7c
to
d22583c
Compare
shuofan
force-pushed
the
feature/issue-manage-filter
branch
from
d22583c
to
33333d1
Compare
sfwn
approved these changes
Jan 4, 2022
|
/approve |
erda-bot
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
feature refactor
What this PR does / why we need it:
Standard issue filter provider, add issue complexity and states
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.