Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column breaking out on firefox when using Contao Content Slider #10

Closed
dennisbohn opened this issue May 13, 2022 · 9 comments
Closed

Column breaking out on firefox when using Contao Content Slider #10

dennisbohn opened this issue May 13, 2022 · 9 comments

Comments

@dennisbohn
Copy link
Contributor

I am using the Grid Bundle in combination with the Contao Content Slider.

It seems there is a problem on Firefox.

https://test.office.bohn.media/

The fourth element is a content slider. Everything seems fine on Chrome and Edge.

image

But in Firefox (Windows, v100.0) the column breaks out when it contains a Content Slider.

image

@denniserdmann
Copy link
Contributor

denniserdmann commented May 13, 2022

Moin Dennis,

i'm not sure, if we can prevent the slider from calculating the wrong width. We had the problem at the optimist-theme too: erdmannfreunde/optimist-theme-bundle#5 (comment)

May you find a general solution, otherwise at least a solution for your case.

@dennisbohn
Copy link
Contributor Author

When I set the column to fixed 640px (see third row) or to "overflow: hidden" the slider calculates the correct width. The problem is, that I want to place the buttons outside the div while I am working with floating widths.

I'll check, if this problem happens with another grid too.

@dennisbohn
Copy link
Contributor Author

dennisbohn commented May 13, 2022

Tested it with "Bootstrap für Contao Grid" and had the same problem.

https://test.office.bohn.media/bootstrap.html

@dennisbohn
Copy link
Contributor Author

dennisbohn commented May 13, 2022

Giving all columns a width of 100% fixed the problem.

.ce_colStart {
    width: 100%;
}

https://test.office.bohn.media/euf.html

@denniserdmann
Copy link
Contributor

Good work. I need to check, if your solution will cause other problems with the grid as there are too many options to keep in mind.

@dennisbohn
Copy link
Contributor Author

Damn, found something that doesnt work anymore when you set the width to 100%. :'(

  • justify-center
  • justify-end

When the boxes grow to 100% the content is still aligned left inside the box. "max-width" seems to work.

.ce_colStart {
    max-width: 100%;
}

https://test.office.bohn.media/euf-maxwidth.html

@denniserdmann
Copy link
Contributor

Can you test, if the following fix is working for you aswell? nutshell-framework/assets@fb4f615#diff-0f8c92d97bbd30a26ba8610e3307d91131a6bd37a91efb1edfc23ffabc21fd55R30

@dennisbohn
Copy link
Contributor Author

It works. Thanks!

@denniserdmann
Copy link
Contributor

fixed in 1.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants