-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random stuck #222
Random stuck #222
Conversation
Hey, just had a look (Sorry for the months long delay) and it looks like the asset build tool we are using started producing a broken generated file. Sadly that project seems a bit abandoned too https://github.com/elazarl/go-bindata-assetfs/issues https://twitter.com/francesc/status/961249107020001280 |
@keis Thanks for the response. diff --git a/go.mod b/go.mod
index ffb8cd2..e09f608 100644
--- a/go.mod
+++ b/go.mod
@@ -8,6 +8,7 @@ require (
github.com/braintree/manners v0.0.0-20150503212558-0b5e6b2c2843
github.com/davecgh/go-spew v1.1.1
github.com/elazarl/go-bindata-assetfs v1.0.0
+ github.com/go-bindata/go-bindata v3.1.2+incompatible // indirect
github.com/gogo/protobuf v0.0.0-20170307180453-100ba4e88506
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
github.com/golang/protobuf v0.0.0-20171021043952-1643683e1b54
@@ -15,11 +16,15 @@ require (
github.com/gorilla/mux v1.4.0
github.com/gorilla/schema v0.0.0-20171101174852-e6c82218a8b3
github.com/jacobsa/oglematchers v0.0.0-20150720000706-141901ea67cd
+ github.com/jacobsa/oglemock v0.0.0-20150831005832-e94d794d06ff // indirect
+ github.com/jacobsa/ogletest v0.0.0-20170503003838-80d50a735a11 // indirect
+ github.com/jacobsa/reqtrace v0.0.0-20150505043853-245c9e0234cb // indirect
github.com/kardianos/osext v0.0.0-20170510131534-ae77be60afb1
github.com/kelseyhightower/envconfig v1.3.0
github.com/kevinburke/go-bindata v3.13.0+incompatible // indirect
github.com/matttproud/golang_protobuf_extensions v1.0.1
github.com/mesos/mesos-go v0.0.0-20170604182343-f2cd423e881b
+ github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect
github.com/pborman/uuid v0.0.0-20160209185913-a97ce2ca70fa
github.com/pmezard/go-difflib v1.0.0
github.com/prometheus/client_golang v0.8.0
@@ -28,11 +33,13 @@ require (
github.com/prometheus/procfs v0.0.0-20171017214025-a6e9df898b13
github.com/samuel/go-zookeeper v0.0.0-20171027001500-9a96098268ef
github.com/sirupsen/logrus v1.4.2
- github.com/smartystreets/goconvey v0.0.0-20190330032615-68dc04aab96a
+ github.com/smartystreets/goconvey v1.6.4
github.com/stretchr/objx v0.1.1
github.com/stretchr/testify v1.2.2
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2
golang.org/x/net v0.0.0-20190311183353-d8887717615a
+ golang.org/x/sync v0.0.0-20200625203802-6e8e738ad208 // indirect
golang.org/x/sys v0.0.0-20190422165155-953cdadca894
+ gopkg.in/check.v1 v1.0.0-20200902074654-038fdea0a05b // indirect
gopkg.in/yaml.v2 v2.0.0-20170812160011-eb3733d160e7
) Is it ok to add these changes? |
@keis I have updated the tests and fixed the ci. |
That security issue seems to be fixed with new repo |
@ja8zyjits Ok that's great! I'll go ahead and merge this then :) |
@keis , thanks for the prompt response. |
Sure thing, I tagged a release but still need to wait for a travis run to get a the new docker image |
mesosphere/universe#2618 |
fixes #187
I just saw the flow of logs, and thought of doing this workaround, will this fix?
The chief issue is the inability to reproduce the issue.