Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add WithoutOptionalStrategy #375

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Conversation

localheinz
Copy link
Member

This PR

  • adds WithoutOptionalStrategy

🤦‍♂️ Something went wrong when rebasing in #369.

@localheinz localheinz self-assigned this Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #375 into main will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #375      +/-   ##
============================================
+ Coverage     99.01%   99.04%   +0.03%     
- Complexity      106      110       +4     
============================================
  Files            24       25       +1     
  Lines           304      315      +11     
============================================
+ Hits            301      312      +11     
  Misses            3        3              
Impacted Files Coverage Δ Complexity Δ
src/FixtureFactory.php 97.94% <100.00%> (+0.05%) 46.00 <1.00> (+1.00)
src/Strategy/WithoutOptionalStrategy.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb051d...b994063. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review August 5, 2020 15:05
@ergebnis-bot ergebnis-bot self-assigned this Aug 5, 2020
@ergebnis-bot ergebnis-bot merged commit 2a906d3 into main Aug 5, 2020
@ergebnis-bot ergebnis-bot deleted the fix/without-optional branch August 5, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants