Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement WithoutOptionalStrategy #369

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

localheinz
Copy link
Member

This PR

  • implements a WithoutOptionalStrategy

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #369 into main will increase coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #369      +/-   ##
============================================
+ Coverage     98.41%   99.01%   +0.60%     
- Complexity       98      107       +9     
============================================
  Files            21       24       +3     
  Lines           252      304      +52     
============================================
+ Hits            248      301      +53     
+ Misses            4        3       -1     
Impacted Files Coverage Δ Complexity Δ
src/FieldDefinition/Reference.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Count.php 100.00% <100.00%> (ø) 8.00 <8.00> (?)
src/Exception/InvalidCount.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/Exception/InvalidDefinition.php 100.00% <100.00%> (ø) 3.00 <3.00> (+2.00)
src/Exception/InvalidMaximum.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/Exception/InvalidMinimum.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/FieldDefinition.php 100.00% <100.00%> (ø) 9.00 <1.00> (-2.00)
src/FieldDefinition/References.php 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
src/FixtureFactory.php 97.88% <100.00%> (-0.35%) 46.00 <20.00> (+4.00) ⬇️
src/Strategy/DefaultStrategy.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0860e6...68e0a6d. Read the comment docs.

@localheinz localheinz marked this pull request as ready for review August 5, 2020 13:55
@ergebnis-bot ergebnis-bot self-requested a review August 5, 2020 13:57
@ergebnis-bot ergebnis-bot self-assigned this Aug 5, 2020
@ergebnis-bot ergebnis-bot merged commit 3a98c1a into main Aug 5, 2020
@ergebnis-bot ergebnis-bot deleted the feature/without-optional branch August 5, 2020 13:57
@localheinz localheinz mentioned this pull request Aug 5, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants