Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Keep constructor parameters, fields, and assignments in order #51

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 15, 2020

This PR

  • keeps constructor parameters, fields, and assignments in EntityDef in consistent order

Follows #1.

@localheinz localheinz added the bug label Mar 15, 2020
@localheinz localheinz self-assigned this Mar 15, 2020
@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage     92.89%   92.89%           
  Complexity       81       81           
=========================================
  Files             8        8           
  Lines           197      197           
=========================================
  Hits            183      183           
  Misses           14       14
Impacted Files Coverage Δ Complexity Δ
src/EntityDef.php 90.9% <100%> (ø) 18 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe49e8f...a25c6e7. Read the comment docs.

@localheinz localheinz merged commit 9df002f into master Mar 15, 2020
@localheinz localheinz deleted the fix/order branch March 15, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant