Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Inline method #59

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fix: Inline method #59

merged 1 commit into from
Mar 23, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 16, 2020 •
edited
Loading

This PR

  • inlines a method

Follows #1.

@localheinz localheinz self-assigned this Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020 •
edited
Loading

Codecov Report

Merging #59 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
- Coverage      93.5%   93.43%   -0.07%     
+ Complexity       79       78       -1     
============================================
  Files             8        8              
  Lines           200      198       -2     
============================================
- Hits            187      185       -2     
  Misses           13       13
Impacted Files Coverage Δ Complexity Δ
src/EntityDef.php 94.87% <100%> (-0.26%) 15 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1b394...a5ae048. Read the comment docs.

@localheinz localheinz force-pushed the feature/merge branch 2 times, most recently from dc4a015 to 9cf862a Compare March 16, 2020 17:43
@localheinz localheinz changed the title Enhancement: Merge methods Fix: Inline method Mar 23, 2020
@localheinz localheinz marked this pull request as ready for review March 23, 2020 18:22
@localheinz localheinz merged commit f4b5392 into master Mar 23, 2020
@localheinz localheinz deleted the feature/merge branch March 23, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@localheinz