Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve referenced schema in oneOf combination #47

Merged
merged 2 commits into from
Feb 15, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Feb 15, 2018

This PR

  • assert that a referenced schema in a oneOf combination is resolved
  • resolves referenced schemas in oneOf combinations

Follows #45.

@localheinz localheinz added the bug label Feb 15, 2018
@localheinz localheinz self-assigned this Feb 15, 2018
@codecov
Copy link

codecov bot commented Feb 15, 2018

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #47   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      104    104           
=======================================
  Files            13     13           
  Lines           290    292    +2     
=======================================
+ Hits            290    292    +2
Impacted Files Coverage Δ Complexity Δ
src/SchemaNormalizer.php 100% <100%> (ø) 38 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432ccef...c91a39b. Read the comment docs.

@localheinz localheinz merged commit 39c3a43 into master Feb 15, 2018
@localheinz localheinz deleted the fix/one-of-has-reference branch February 15, 2018 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant