Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Keep resolving references until there are none left #49

Merged
merged 2 commits into from
Feb 15, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Feb 15, 2018

This PR

  • assers that nested references are resolved
  • resolves references until there are none left

Follows #47.

@localheinz localheinz added the bug label Feb 15, 2018
@localheinz localheinz self-assigned this Feb 15, 2018
@localheinz localheinz changed the title Enhancement: Assert that schema is resolved until there are no references left Fix: Keep resolving references Feb 15, 2018
@localheinz localheinz changed the title Fix: Keep resolving references Fix: Keep resolving references until there are none left Feb 15, 2018
@codecov
Copy link

codecov bot commented Feb 15, 2018

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #49   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      104    104           
=======================================
  Files            13     13           
  Lines           292    294    +2     
=======================================
+ Hits            292    294    +2
Impacted Files Coverage Δ Complexity Δ
src/SchemaNormalizer.php 100% <100%> (ø) 38 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5e578...783b808. Read the comment docs.

@localheinz localheinz merged commit 0bcf045 into master Feb 15, 2018
@localheinz localheinz deleted the fix/keep-resolving-reference branch February 15, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant