Enhancement: Implement Classes\PHPUnit\Framework\TestCaseWithSuffixRule

[localheinz]

This PR

• implements Classes\PHPUnit\Framework\TestCaseWithSuffixRule, which reports an error when a concrete sub-class of PHPUnit\Framework\TestCase does not have a Test suffix

[codecov]

Codecov Report

Merging #225 into master will decrease coverage by 0.44%.
The diff coverage is 77.41%.

@@             Coverage Diff              @@
##             master     #225      +/-   ##
============================================
- Coverage     84.32%   83.88%   -0.45%     
- Complexity      138      149      +11     
============================================
  Files            22       23       +1     
  Lines           453      484      +31     
============================================
+ Hits            382      406      +24     
- Misses           71       78       +7     

Impacted Files	Coverage Δ	Complexity Δ
...asses/PHPUnit/Framework/TestCaseWithSuffixRule.php	77.41% <77.41%> (ø)	11.00 <11.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cebf79a...bdccf23. Read the comment docs.

[TomasVotruba]

Looks like class name in PR description is too short.

Should be Ergebnis\PHPStan\Rules\Classes\PHPUnit\Framework\TestCaseWithSuffixRule instead

[TomasVotruba]

It doesn't work for me :/

# phpstan.neon
services:
    -
         class: Ergebnis\PHPStan\Rules\Classes\PHPUnit\Framework\TestCaseWithSuffixRule
         tags:
                 - phpstan.rules.rule

<?php

use PHPUnit\Framework\TestCase

// this should report error, but missed
class JsonOutputFormatterA extends AbstractKernelTestCase {
}

class AbstractKernelTestCase extends TestCase {
}

[TomasVotruba]

Running clear cache didn't help:

vendor/bin/phpstan clear-result-cache

[TomasVotruba]

Weird. Running PHPStan with --debug helped