Bump support for PHPStan to version 1.0 #381
Conversation
| @@ -120,7 +120,12 @@ private function isWhitelisted(Node $node): bool | |||
| return false; | |||
| } | |||
|
|
|||
| if (\is_int(\preg_match_all('/@(\S+)(?=\s|$)/', $docComment->getReformattedText(), $matches))) { | |||
| $reformattedComment = $docComment->getReformattedText(); | |||
| if (!\is_string($reformattedComment)) { | |||
There was a problem hiding this comment.
getReformattedText now returns string|mixed, so we need to make sure it's a string before we pass it to preg_match_all which strictly expects a string.
|
@localheinz since this is my first contribution to this repo, could you please approve the running of the workflows? |
Codecov Report
@@ Coverage Diff @@
## main #381 +/- ##
============================================
- Coverage 90.20% 90.04% -0.17%
- Complexity 150 151 +1
============================================
Files 23 23
Lines 429 432 +3
============================================
+ Hits 387 389 +2
- Misses 42 43 +1
Continue to review full report at Codecov.
|
|
I'm not sure what I did notice that PHPStan 1.0 is shipped as a PHAR file, maybe |
|
@localheinz all issues have been resolved or explained why they can't be resolved IMO 😁 |
localheinz
force-pushed
the
phpstan-1.0
branch
5 times, most recently
from
bfb993b
to
41a6dd9
Compare
localheinz
force-pushed
the
phpstan-1.0
branch
from
41a6dd9
to
a13fee6
Compare
I am sure that this is the problem, let's ignore these issues for now! |
|
Thank you, @rpkamp! Will cut a release shortly! |
This pull request
Fixes #379
These are the only deprecations I could find.
vendor/bin/phpstanandvendor/bin/phpunit test/passed locally.I hope I didn't miss anything that other tooling would catch 🤞