Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement NoConstructorParameterWithDefaultValueRule #45

Merged

Conversation

localheinz
Copy link
Member

This PR

  • implements Methods\NoConstructorParameterWithDefaultValueRule, which reports an error when a constructor in an anonymous class or a class has a parameter with a default value

@localheinz localheinz self-assigned this Dec 3, 2018
@localheinz localheinz force-pushed the feature/no-constructor-parameter-with-default-value branch from 253a0cc to c93ce4d Compare December 3, 2018 20:28
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #45   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       53     59    +6     
=======================================
  Files            11     12    +1     
  Lines           182    209   +27     
=======================================
+ Hits            182    209   +27
Impacted Files Coverage Δ Complexity Δ
...ods/NoConstructorParameterWithDefaultValueRule.php 100% <100%> (ø) 6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687bada...ffe3aae. Read the comment docs.

@localheinz localheinz force-pushed the feature/no-constructor-parameter-with-default-value branch from c93ce4d to ffe3aae Compare December 3, 2018 20:52
@localheinz localheinz merged commit cde960d into master Dec 4, 2018
@localheinz localheinz deleted the feature/no-constructor-parameter-with-default-value branch December 4, 2018 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant