Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove default values from constructor parameters of Classes\FinalRule #53

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 5, 2018

This PR

  • removes default values from constructor parameters of Classes\FinalRule

Follows #45.
Follows #51.

@localheinz localheinz added the bug label Dec 5, 2018
@localheinz localheinz self-assigned this Dec 5, 2018
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #53   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       55     55           
=======================================
  Files            11     11           
  Lines           201    201           
=======================================
  Hits            201    201
Impacted Files Coverage Δ Complexity Δ
src/Classes/FinalRule.php 100% <100%> (ø) 9 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2e185...c0c45d9. Read the comment docs.

@localheinz localheinz force-pushed the fix/no-constructor-parameter-with-default-value branch from 76b826f to 19f485a Compare December 5, 2018 14:33
@localheinz localheinz force-pushed the fix/no-constructor-parameter-with-default-value branch from 19f485a to c0c45d9 Compare December 5, 2018 14:53
@localheinz localheinz merged commit 6e1f21e into master Dec 5, 2018
@localheinz localheinz deleted the fix/no-constructor-parameter-with-default-value branch December 5, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant