Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow registering 0 as an account name #1896

Closed
slingamn opened this issue Jan 9, 2022 · 0 comments
Closed

disallow registering 0 as an account name #1896

slingamn opened this issue Jan 9, 2022 · 0 comments
Labels
bug
Milestone
v2.10

Comments

@slingamn
Copy link
Member

slingamn commented Jan 9, 2022

0 is the WHOX placeholder value for "user is not logged into an account": ircv3/ircv3-specifications#482

On conventional IRC implementations, this is safe because 0 is treated specially by the S2S protocol and nickname handling. On Ergo, 0 is just another nickname. We should prevent users from registering 0 as an account because of the ambiguity. (We may also want to prevent the use of 0 as a nickname.)
@slingamn slingamn added the bug label Jan 9, 2022
@slingamn slingamn added this to the v2.10 milestone Jan 9, 2022
slingamn added a commit that referenced this issue Jan 20, 2022
@slingamn
Merge pull request #1903 from slingamn/zero_nick
fa7b76d 
fix #1896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.10
Development

No branches or pull requests
1 participant
@slingamn