Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out NS GROUP and NS GHOST when nickname reservation is disabled #727

Closed
slingamn opened this issue Dec 31, 2019 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@slingamn
Copy link
Member

This is from a report in #oragono. In theory, you should be able to GROUP an additional nick name and then GHOST it even when nickname reservation is disabled. However, there may be up to two bugs in this functionality:

  1. NS GROUP is disabled when nickname reservation is disabled
  2. NS GHOST doesn't work unless the nickname-to-account index is built, and if reservation is disabled, it won't be
@slingamn slingamn added the bug label Dec 31, 2019
@slingamn slingamn added this to the v1.3 milestone Dec 31, 2019
@slingamn
Copy link
Member Author

slingamn commented Jan 1, 2020

Actually, now I'm uncertain whether we actually want these features to work when nickname reservation is disabled. The way to enable the permissive mode (no proactive enforcement, but GROUP and GHOST allowed) should probably be "nickname reservation enabled, default enforcement method optional", which currently works as expected. (This is "traditional" in some sense but I do not like it, so I don't want to encourage people to use it; I'd rather people used strict nickname enforcement.)

If it turns out we don't want these features to work with nickname reservation disabled, we should make GHOST fully disabled when nickname reservation is disabled.

@slingamn
Copy link
Member Author

slingamn commented Jan 1, 2020

I think the approach described in the previous comment (no GHOST or GROUP when nickname reservation is disabled) is correct.

What I'm uncertain about now is whether to change the example oragono.yaml so it defaults to nick reservation being on, with default enforcement method optional. I'm a little torn about this because it discourages operators from choosing strict instead.

@slingamn slingamn self-assigned this Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant