Update draft/rename impl #1223
Merged
Update draft/rename impl #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much, this is a huge help! I'll review this soon; I'm going to ask some questions about the "silent" case changes. In general I'm trying to move more towards a setup where clients can treat all server-sent identifiers as opaque byte strings (see #1083 in particular). |
|
From discussion on ircv3/ircv3-specifications#420, can you ensure the fallback is sent for case changes? |
|
Still todo: use the stored channel name instead of |
|
This looks great! Would you mind squashing it yourself? |
slingamn
reviewed
Aug 5, 2020
irc/handlers.go
Outdated
| @@ -2434,21 +2433,23 @@ func renameHandler(server *Server, client *Client, msg ircmsg.IrcMessage, rb *Re | |||
| rb.Add(nil, server.name, ERR_NOSUCHCHANNEL, client.Nick(), utils.SafeErrorParam(oldName), client.t("No such channel")) | |||
| return false | |||
| } | |||
| oldName = channel.name | |||
There was a problem hiding this comment.
Oh, sorry, this should use channel.Name()
Link to the new draft PR: <ircv3/ircv3-specifications#420> Changes in the spec: - Use standard replies instead of numerics: <https://github.com/ircv3/ircv3-specifications/pull/420/files#diff-70e90beef48dc9cf5d784d1e179ea822R44> - Allow RENAME to a different case: <https://github.com/ircv3/ircv3-specifications/pull/420/files#diff-70e90beef48dc9cf5d784d1e179ea822R42> This commit makes oragono send the PART-JOIN fallback even on case-only changes. This is so that clients don't have to worry about oragono's UTF8 casefolding. See the following comments for further info: <ircv3/ircv3-specifications#420 (comment)> Misc fixes: - Remove unused variable, - Add missing calls to utils.SafeErrorParam, - Don't fill replies with the user-provided "oldName", for the same reason as sending the PART-JOIN fallback.
|
The cap name is now draft/channel-rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1122
New draft: ircv3/ircv3-specifications#420
Former draft: ircv3/ircv3-specifications#308
Quoting the new draft commit message:
Feel free to squash before merging.