Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make MONITOR more compatible with blackbox casefolding? #1083

Closed
slingamn opened this issue May 28, 2020 · 1 comment
Closed

make MONITOR more compatible with blackbox casefolding? #1083

slingamn opened this issue May 28, 2020 · 1 comment
Milestone
v2.2

Comments

@slingamn
Copy link
Member

Something I've been thinking about is that to the maximum extent possible, clients shouldn't have to be aware of casefolding. In other words:

  1. Clients should be able to treat all nicknames and channel names as opaque byte strings
  2. We should always send the canonical (unfolded) form of the identifier
  3. Folding should be thought of primarily as a

In the case of MONITOR, MONITOR L sends the folded identifier. It might be better to send the form the client originally sent.
@DanielOaks
Copy link
Member

Makes sense 100%. canonical forms being sent to clients always is optimal for sure~

@slingamn slingamn added this to the v2.2 milestone Jun 1, 2020
@slingamn slingamn assigned slingamn and unassigned slingamn Jun 15, 2020
slingamn added a commit to slingamn/ergo that referenced this issue Jun 22, 2020
@slingamn
fix ergochat#1053, ergochat#1083
cb53005
slingamn added a commit that referenced this issue Jun 23, 2020
@slingamn
Merge pull request #1150 from slingamn/monitor.1
7ee7b1a 
fix #1053, #1083
@slingamn slingamn mentioned this issue Aug 4, 2020
Merged
@slingamn slingamn mentioned this issue Jan 1, 2021
Open
@slingamn slingamn mentioned this issue Jun 20, 2021
Closed
@slingamn slingamn mentioned this issue Jun 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
2 participants
@DanielOaks @slingamn