This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
test: Product Relation Mapper #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiewiurdp
approved these changes
May 13, 2021
piotrkreft
suggested changes
May 13, 2021
| use PHPUnit\Framework\MockObject\MockObject; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class AbstractProductRelationAttributeCase extends TestCase |
There was a problem hiding this comment.
Suggested change
| class AbstractProductRelationAttributeCase extends TestCase | |
| abstract class AbstractProductRelationMapperAttributeCase extends TestCase |
There was a problem hiding this comment.
Actually, this should fail(via warning) as you have no tests in your class
There was a problem hiding this comment.
Ahhh it does not have Test suffix so that's the reason probably :)
|
|
||
| protected function getProductCrossSellingClass(): AbstractProductCrossSelling | ||
| { | ||
| return new class( |
|
|
||
| public function testNoAttribute(): void | ||
| { | ||
| $this->product->expects(self::once())->method('hasAttribute')->willReturn(false); |
There was a problem hiding this comment.
It's a fake test. It should test method output, not the fact a method is called once
piotrkreft
approved these changes
May 13, 2021
wiewiurdp
approved these changes
May 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.