Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds addSignWithDhtData so user can sign a transaction w/ single dht tuple #24

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

techiejd
Copy link
Contributor

It's used like this: https://scastie.scala-lang.org/x6bwPi9eRDiqX4m1cEJsNg

It works locally. Ideally, there'd be an available test suite but I'm having trouble locating it. So, if someone could take a look at this PR and explain if there are other steps.

Thanks.

Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Please check my suggestions.

Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looking great! Please, make Ci green (formatting).

Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@greenhat greenhat merged commit 44f4f73 into ergoplatform:develop Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants