Candidate for 5.0.17 release #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for garbage-collecting utxo with invalid ergo tree
Change logging maxHistory to 1 week
Minor refactorings Moved some scorex.core classes into org.ergoplatform To simplify creation of alternative clients for Ergo.
Extract NiPoPow
…edErgoTransaction
#2051 Add limit and offset parameter to /wallet/boxes/unspent
After-#2060 refactoring
# Conflicts: # ergo-core/src/main/scala/org/ergoplatform/http/api/ApiCodecs.scala # src/main/scala/org/ergoplatform/http/api/BlockchainApiRoute.scala # src/main/scala/org/ergoplatform/nodeView/history/extra/ExtraIndexer.scala # src/main/scala/org/ergoplatform/nodeView/history/extra/IndexedErgoTransaction.scala
…nto i2066-indexer-rework
ccellado
approved these changes
Dec 19, 2023
aslesarenko
reviewed
Dec 19, 2023
| val scanId = ScanId @@ scanIdInt.toShort | ||
| val considerUnconfirmed = minConfNum == -1 | ||
| withWallet(_.scanUnspentBoxes(scanId, considerUnconfirmed, minHeight, maxHeight).map { | ||
| _.filter(boxConfirmationFilter(_, minConfNum, maxConfNum)) | ||
| .slice(offset, offset + limit) |
There was a problem hiding this comment.
Shouldn't the slicing be pushed down to the data extraction stack?
|
|
||
| val ASC: Direction = 1.asInstanceOf[Direction] | ||
| val DESC: Direction = 0.asInstanceOf[Direction] | ||
| val INVALID: Direction = (-1).asInstanceOf[Direction] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate for 5.0.17 reference client release. It contains following PRs: