Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2051 Add limit and offset parameter to /wallet/boxes/unspent #2074

Merged
merged 5 commits into from Dec 13, 2023

Conversation

anon-yum
Copy link
Contributor

@anon-yum anon-yum commented Dec 7, 2023

This PR addresses:
#2051

and adds limit and offset to wallet/boxes/unspent, using default value of 50 for limit and max value of 500 for limit. Includes basic parameter checks and uses slice to apply offset and limit

@anon-yum
Copy link
Contributor Author

anon-yum commented Dec 7, 2023

Changed to default of 500 and max of 2500 to accommodate for anyone expecting larger responses by default.

Copy link
Member

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but scan/ methods descriptions not updated in openapi.yaml

@kushti kushti changed the base branch from master to v5.0.17 December 13, 2023 20:54
@kushti kushti merged commit 6cecf7e into ergoplatform:v5.0.17 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants