Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in test_exact(): change BaseSettings to BaseDBConfig #20

Closed
andrey-lepekhin opened this issue Nov 28, 2023 · 0 comments · Fixed by #21
Closed

bug in test_exact(): change BaseSettings to BaseDBConfig #20

andrey-lepekhin opened this issue Nov 28, 2023 · 0 comments · Fixed by #21
Assignees
@andrey-lepekhin

Comments

@andrey-lepekhin
Copy link
Collaborator

pydjantic/tests/test_db_config.py

Line 79 in e7c4565

class DatabaseConfig(BaseSettings):

Right now we're testing Pydantic's serialization only with no Pydjantic code.
It should be DatabaseConfig(BaseDBConfig).
@andrey-lepekhin andrey-lepekhin self-assigned this Nov 28, 2023
andrey-lepekhin pushed a commit that referenced this issue Nov 28, 2023
Fix #20 changed BaseSettings to BaseDBConfig
c2603a6
@andrey-lepekhin andrey-lepekhin mentioned this issue Nov 28, 2023
Merged
@andrey-lepekhin andrey-lepekhin linked a pull request Nov 28, 2023 that will close this issue
Fix #20 changed BaseSettings to BaseDBConfig #21
Merged
erhosen pushed a commit that referenced this issue Nov 28, 2023
@andrey-lepekhin
Fix #20 changed BaseSettings to BaseDBConfig (#21)
a54a73e 
Co-authored-by: Andrey Lepekhin <andrey@lepekhin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrey-lepekhin andrey-lepekhin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #20 changed BaseSettings to BaseDBConfig erhosen-libs/pydjantic
1 participant
@andrey-lepekhin