Add install_requires argument in setup.py file

[ragnarokatz]

referenced issue #2

[eric-s-s]

excellent! a bug is found! perhaps there was a newer version of one of the libraries that now behaves differently. i will try to look into this in the next few days, or if you want to hunt it down, that would be great!

[eric-s-s]

I found the issue. All regular exceptions are now converted to InternalServerError connections within the app

https://flask.palletsprojects.com/en/1.1.x/errorhandling/#handling

this might need a re-write to deal with new situation

[eric-s-s]

and the breaking change came from here:

https://flask.palletsprojects.com/en/1.1.x/errorhandling/#unhandled-exceptions

[ragnarokatz]

@eric-s-s correct. This exception's the root cause is here:

test_bind_json_error_handlers_non_HTTPException_error_as_acting_in_app (tests.test_bind_json_error_handler.TestBindJSONErrorHandler) ... [2019-10-09 18:29:21,297] ERROR in app: Exception on /error/other [GET]
Traceback (most recent call last):
  File "/home/travis/build/eric-s-s/bind_json_error_handlers/tests/test_bind_json_error_handler.py", line 20, in get_errors
    raise error_dict[error_name](description=TEST_MESSAGE)
KeyError: 'other'

then flask just took this unhandled exception and threw a generic 500 internal server error instead.

[eric-s-s]

If you're up for fixing the problem, go for it! I'd still like to send information about the unhandled exception. If not, let me know and I'll get around to it in a few days.

[ragnarokatz]

@eric-s-s hey, I gave it a try.

in test case test_bind_json_error_handlers_non_HTTPException_error_as_acting_in_app,
the list of default_exceptions from werkzeug.exceptions does not include the key other.

Here are the available keys from default_exceptions:

['BadRequest', 'Unauthorized', 'Forbidden', 'NotFound', 'MethodNotAllowed', 'NotAcceptable', 'RequestTimeout', 'Conflict', 'Gone', 'LengthRequired', 'PreconditionFailed', 'RequestEntityTooLarge', 'RequestURITooLarge', 'UnsupportedMediaType', 'RequestedRangeNotSatisfiable', 'ExpectationFailed', 'ImATeapot', 'UnprocessableEntity', 'Locked', 'FailedDependency', 'PreconditionRequired', 'TooManyRequests', 'RequestHeaderFieldsTooLarge', 'UnavailableForLegalReasons', 'InternalServerError', 'NotImplemented', 'BadGateway', 'ServiceUnavailable', 'GatewayTimeout', 'HTTPVersionNotSupported']

[ragnarokatz]

As a result of this, the test case test_create_test_app_TypeError should fail as well. it's just the test hasn't gotten to that stage yet.

for a solution, should I just add 'other' as a key to the dictionary?