Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names #11

Merged
merged 10 commits into from
Apr 9, 2024
Merged

Names #11

merged 10 commits into from
Apr 9, 2024

Conversation

MaxChungsh
Copy link
Collaborator

No description provided.

Copy link
Owner

@eric15342335 eric15342335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to run clang-format

names.cpp Outdated Show resolved Hide resolved
names.cpp Outdated Show resolved Hide resolved
names.cpp Outdated Show resolved Hide resolved
names.h Show resolved Hide resolved
@eric15342335
Copy link
Owner

Think a better name for this pull request, since it will get used as the commit message when you squash merge, and it will deduct our mark if the commit message is bad like this.
Something like Names: Implement names generation algorithm for some categories

@eric15342335 eric15342335 mentioned this pull request Apr 9, 2024
84ds84d8s
84ds84d8s previously approved these changes Apr 9, 2024
Copy link
Collaborator

@84ds84d8s 84ds84d8s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@eric15342335
Copy link
Owner

Just formatting changes, @84ds84d8s no need review it again.

@eric15342335 eric15342335 merged commit fca7587 into main Apr 9, 2024
1 check passed
@eric15342335 eric15342335 deleted the names branch April 11, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp: names Generate name of the stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants