Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift of focus to percentage change random generation, with migration to float from double #12

Closed
wants to merge 3 commits into from
Closed

Shift of focus to percentage change random generation, with migration to float from double #12

wants to merge 3 commits into from

Conversation

84ds84d8s
Copy link
Collaborator

The raw stock price would now be calculated from the generated % change instead of generated directly.
Used float instead as requested.

eric15342335
eric15342335 previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Owner

@eric15342335 eric15342335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You may wish to wait #14 #11 #13 to get merged so that we can test compile the program entirely, or merge this if you like.
Squash merge thanks.

random_price.cpp Show resolved Hide resolved
@eric15342335
Copy link
Owner

This commit message can be improved:
random: Use percentage change of stock price instead of values
And the body paragraph can say:
Convert `double` to `float` as well.

@eric15342335 eric15342335 added the Comp: random Use of srand(), rand(), anything with the word "random" label Apr 9, 2024
@eric15342335 eric15342335 added this to the Third Meeting milestone Apr 9, 2024
@eric15342335 eric15342335 mentioned this pull request Apr 9, 2024
Merged
eric15342335
eric15342335 requested changes Apr 10, 2024
View reviewed changes
Copy link
Owner

@eric15342335 eric15342335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold this, need more discussion.
This code is affecting @MaxChungsh @eric15342335 and the whole gameplay in general.

@84ds84d8s
Copy link
Collaborator Author

Focus has been shifted and this pull request is outdated.

@84ds84d8s 84ds84d8s closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric15342335 eric15342335 eric15342335 requested changes

@Prismatiscence Prismatiscence Awaiting requested review from Prismatiscence

@comet13579 comet13579 Awaiting requested review from comet13579

@MaxChungsh MaxChungsh Awaiting requested review from MaxChungsh

Assignees

@84ds84d8s 84ds84d8s

Labels
Comp: random Use of srand(), rand(), anything with the word "random"
Projects
None yet
Milestone
Third Meeting
Development

Successfully merging this pull request may close these issues.
2 participants
@84ds84d8s @eric15342335