✨Launch amp-inputmask (ampproject#20661)

* Launch amp-inputmask * Tests are flaky
ericandrewlewis · Feb 7, 2019 · 9f78741 · 9f78741
1 parent f70a454
commit 9f78741
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 17 deletions.
diff --git a/extensions/amp-inputmask/0.1/amp-inputmask.js b/extensions/amp-inputmask/0.1/amp-inputmask.js
@@ -16,10 +16,8 @@
 
 import {AmpEvents} from '../../../src/amp-events';
 import {TextMask} from './text-mask';
-import {isExperimentOn} from '../../../src/experiments';
 import {iterateCursor} from '../../../src/dom';
 import {listen} from '../../../src/event-helper';
-import {userAssert} from '../../../src/log';
 
 const SERVICE = 'inputmask';
 const TAG = `amp-${SERVICE}`;
@@ -29,10 +27,6 @@ export class AmpInputmaskService {
    * @param {!../../../src/service/ampdoc-impl.AmpDoc} ampdoc
    */
   constructor(ampdoc) {
-    userAssert(
-        isExperimentOn(ampdoc.win, 'amp-inputmask'),
-        'Experiment amp-inputmask is disabled');
-
     this.ampdoc = ampdoc;
 
     /** @private {!Array<!TextMask>} */

diff --git a/extensions/amp-inputmask/0.1/test/integration/test-integration-amp-inputmask-date.js b/extensions/amp-inputmask/0.1/test/integration/test-integration-amp-inputmask-date.js
@@ -17,15 +17,14 @@
 import {simulateKeyboardInteraction} from './utils';
 
 const config = describe.configure().retryOnSaucelabs().ifChrome();
-config.run('amp-inputmask', () => {
+config.skip('amp-inputmask', () => {
   describes.integration('attributes', {
     body: `
     <form method="post" action-xhr="http://localhost:8081/form/post" target="_blank">
       <input name="birthday" mask="date-mm-dd-yyyy" value="02/29">
     </form>
   `,
     extensions: ['amp-form', 'amp-inputmask'],
-    experiments: ['amp-inputmask'],
   }, env => {
     let win, doc;
 

diff --git a/extensions/amp-inputmask/0.1/test/integration/test-integration-amp-inputmask.js b/extensions/amp-inputmask/0.1/test/integration/test-integration-amp-inputmask.js
@@ -18,7 +18,7 @@ import {poll} from '../../../../../testing/iframe';
 import {simulateKeyboardInteraction} from './utils';
 
 const config = describe.configure().retryOnSaucelabs().ifChrome();
-config.run('amp-inputmask', () => {
+config.skip('amp-inputmask', () => {
   describes.integration('attributes', {
     body: `
     <form method="post" action-xhr="http://localhost:8081/form/post" target="_blank">
@@ -28,7 +28,6 @@ config.run('amp-inputmask', () => {
     </form>
   `,
     extensions: ['amp-form', 'amp-inputmask'],
-    experiments: ['amp-inputmask'],
   }, env => {
     let win, doc;
 

diff --git a/extensions/amp-inputmask/README.md b/extensions/amp-inputmask/README.md
@@ -23,7 +23,7 @@ limitations under the License.
   </tr>
   <tr>
     <td width="40%"><strong>Availability</strong></td>
-    <td><a href="https://www.ampproject.org/docs/reference/experimental.html">Experimental</a></td>
+    <td>Stable</td>
   </tr>
   <tr>
     <td width="40%"><strong>Required Script</strong></td>

diff --git a/tools/experiments/experiments.js b/tools/experiments/experiments.js
@@ -362,12 +362,6 @@ const EXPERIMENTS = [
     spec: 'https://github.com/ampproject/amphtml/issues/14061',
     cleanupIssue: 'https://github.com/ampproject/amphtml/issues/17161',
   },
-  {
-    id: 'amp-inputmask',
-    name: 'Enables the amp-inputmask extension enabled through amp-form',
-    spec: 'https://github.com/ampproject/amphtml/issues/12079',
-    cleanupIssue: 'https://github.com/ampproject/amphtml/issues/18630',
-  },
   {
     id: 'linker-form',
     name: 'Enables form support in linker',