Fix multiple instances bug

[sebgie]

closes #28

• added stopdone to wait for server to stop
• renamed done to startdone
• added testsequence which is able to reproduce the bug without my changes to server.js

[ericclemmons]

Thanks for this! I didn't even think about this issue!

[ericclemmons]

v0.4.8 is published with your fix! Thank you!

[sebgie]

np, thank you for merging/publishing almost instantly 👍

[ericclemmons]

It was the tests :) When there's a PR without tests, it takes me a while to understand the actual problem, but you described that really freakin' well, too!

[ericclemmons]

Ok, there's an issue reported in #30, but your changes to Gruntfile.js doesn't exhibit a problem when using v0.4.7. I may need to revert unless you can help resolve the issue in #30, or help illustrate the problem you were having (that I can't replicate currently) so both issues are resolved.

[sebgie]

Sorry for causing problems :-/. I'll have a look at it in the morning.

[ericclemmons]

You little trouble-maker you! :)

[sebgie]

Ok, I see the following error when adding the test sequence in gruntfile.js. I'm testing with:

• OS X 10.9
• node v0.10.22
• grunt-cli v0.1.9
• grunt v0.4.2

Running "nodeunit:custom_delay" (nodeunit) task
Testing custom_delay_test.js..OK
>> 4 assertions passed (44ms)

Running "express:custom_delay:stop" (express) task
Stopping Express server

Running "express:custom_delay" (express) task
Starting background Express server

Running "nodeunit:custom_delay" (nodeunit) task
Testing custom_delay_test.jsFF
>> custom_delay - test_runs_after_timeout
>> Error: Expected 2 assertions, 0 ran
>> at ClientRequest.<anonymous> (test/custom_delay_test.js:22:12)
>> at ClientRequest.EventEmitter.emit (events.js:95:17)
>> at Socket.socketErrorListener (http.js:1520:9)
>> at Socket.EventEmitter.emit (events.js:95:17)
>> at net.js:426:14
>> at process._tickCallback (node.js:415:13)

>> custom_delay - test_runs_in_development
>> Error: Expected 2 assertions, 0 ran
>> at ClientRequest.<anonymous> (test/custom_delay_test.js:34:12)
>> at ClientRequest.EventEmitter.emit (events.js:95:17)
>> at Socket.socketErrorListener (http.js:1520:9)
>> at Socket.EventEmitter.emit (events.js:95:17)
>> at net.js:426:14
>> at process._tickCallback (node.js:415:13)

Warning: 2/2 assertions failed (13ms) Use --force to continue.