Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: starting multiple instances causes error #28

Closed
sebgie opened this issue Dec 5, 2013 · 1 comment · Fixed by #29 or #31
Closed

Bug: starting multiple instances causes error #28

sebgie opened this issue Dec 5, 2013 · 1 comment · Fixed by #29 or #31

Comments

@sebgie
Copy link
Contributor

sebgie commented Dec 5, 2013

We use grunt-express-server for automated Travis builds. Our tests start the same instance of an express server multiple times in a row. The following flow is the result:

  • express:test (waiting for output)
  • output detected and finished() -> done() is executed
  • express:test:stop
  • express:test (waiting for output)
  • doneFunction of grunt.util.spawn() executes finished() -> done() and the second server is not waiting for output anymore.
sebgie added a commit to sebgie/grunt-express-server that referenced this issue Dec 5, 2013
closes ericclemmons#28
- added stopdone to wait for server to stop
- renamed done to startdone
- added testsequence which is able to reproduce the bug without my
changes
@ericclemmons
Copy link
Owner

Published v0.4.8 with this fix. Thanks for the test, detailed bug report, and the extremely simple fix :)

sebgie added a commit to sebgie/grunt-express-server that referenced this issue Dec 6, 2013
closes ericclemmons#28
closes ericclemmons#30
- added stopdone to wait for server to stop
- renamed done to startdone
- added conditional for `grunt.task.current.async()`
- added testsequence which is able to reproduce the bug without my
changes to server.js
- added `express:defaults` without `express:defaults:stop` at the end
of the file to reproduce missing 'async'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants