Use path.win32 from "path" over importing from "path/win32"
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because `path/win32` was only added in Node.js v16. In Node.js v10 to v14 only `path.win32` is available (which is still available in v16, and v17, as well).
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 701 701
=========================================
Hits 701 701
|
And all "normal" tests only on the development Node.js version. This is necessary because the source code is written in ESM, but Node v10.13.0 does not support ESM, so running the "normal" tests is non-trivial. Running the CommonJS test suite on every supported Node.js version will at least catch faulty imports and, to an extends, faulty implementations for older Node.js versions.
See Node.js v10.x documentation for assert: https://nodejs.org/dist/latest-v10.x/docs/api/assert.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197