Update Windows escaping for the exact character sequence \n\r
#458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ericcornelissen
commented
Oct 8, 2022
•
ericcornelissen
commented
- Update the fixtures (dcf9559)
- Update the implementation (e3b42d7)
- Update the changelog (992a29d)
Update the text fixtures for Windows that test that `\n\r` is escaped such that the expected value has just one space for the exact sequence of characters `\n\r`.
Codecov Report
@@ Coverage Diff @@
## main #458 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 785 785
=========================================
Hits 785 785
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ericcornelissen
force-pushed
the
win-escaping-newlines
branch
3 times, most recently
from
7f85b1e
to
db36de6
Compare
ericcornelissen
force-pushed
the
win-escaping-newlines
branch
from
db36de6
to
f28a5ae
Compare
Update the fuzz normalization for CMD and PowerShell in alignment with the changes to the newline substitution in the source code.
ericcornelissen
force-pushed
the
win-escaping-newlines
branch
from
f28a5ae
to
8ee3aca
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.