Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct \n\r to \r\n #460

Merged
merged 2 commits into from
Oct 9, 2022
Merged

Correct \n\r to \r\n #460

merged 2 commits into from
Oct 9, 2022

Conversation

ericcornelissen
Copy link
Owner

@ericcornelissen ericcornelissen commented Oct 9, 2022

Followup to #458
Relates to #456

Windows newlines are <carriage return>+<line feed>, not <line feed>
+<carriage return>.
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #460 (6560d61) into main (e540b7e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #460   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          785       785           
=========================================
  Hits           785       785           
Flag Coverage Δ
e2e-macos-latest 83.18% <0.00%> (ø)
e2e-ubuntu-latest 82.67% <0.00%> (ø)
integration-macos-latest 89.42% <0.00%> (ø)
integration-ubuntu-latest 89.55% <0.00%> (ø)
integration-windows-latest 86.87% <100.00%> (ø)
property 96.94% <100.00%> (ø)
unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/win.js 100.00% <100.00%> (ø)

@ericcornelissen ericcornelissen enabled auto-merge (squash) October 9, 2022 10:33
@ericcornelissen ericcornelissen merged commit d8c868d into main Oct 9, 2022
@ericcornelissen ericcornelissen deleted the win-escaping-newlines-2 branch October 9, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant