Fix for Issue 19: Makes actions into a map with action names for keys #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this fundamentally changes the exposed interface of
dsm, this is a breaking change.As discussed in #19, it is useful to be able to access the actions the same way we access the action creators using the
actionCreatorNames(which I've renamedactionNames). I have implemented this by basically stealing the original methodology that built the action creators map and now use it to build the actions. This in turn required changing the way the action creators map is built, but only trivially.I have updated the tests and README to reflect the change of the
actionsdata structure.