Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for node 12 #12

Merged
merged 1 commit into from
Oct 24, 2020
Merged

fix for node 12 #12

merged 1 commit into from
Oct 24, 2020

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Sep 1, 2019

Closes #11

@ericfreese
Copy link
Owner

@Protryon

@aminya
Copy link
Collaborator

aminya commented Jul 21, 2020

Any chance we can merge this? The current package does not work and it is not useful anymore.

@ericfreese

@aminya
Copy link
Collaborator

aminya commented Jul 21, 2020

There is a fork here https://github.com/julusian/node-freetype2 by @Julusian. Could you help marging this?

@Julusian
Copy link
Contributor

@aminya I am not expecting for my fork to be merged in, partly as this library does not appear to be maintained anymore, and due to the large scope of my changes.
I ended up pretty much completely rewriting the library while doing that, as I switched to the new native module api and needed to review all the existing code anyway as it was surprisingly easy to trigger a segfault.

The api should be mostly the same, but there are some differences and it is possible I didnt implement some bits yet too.
As a bonus, it shouldnt require much maintenance due to using the new native api, but I intend to look after it.

Copy link
Collaborator

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this. It works.

I integrated this to the Atom package: ericfreese/font-viewer#23. You can see it in action.

@aminya
Copy link
Collaborator

aminya commented Jul 21, 2020

@Julusian We can first start by this pull request and then we can merge your fork.

@ericfreese
Copy link
Owner

@Protryon is the current maintainer of this package as of #10 (comment). If he doesn't respond soon, would you be interested in taking over @aminya?

@aminya
Copy link
Collaborator

aminya commented Jul 21, 2020

@ericfreese Sure! I will be happy to do so.

@aminya
Copy link
Collaborator

aminya commented Aug 3, 2020

@ericfreese it seems that the previous maintainer is not active anymore

@Julusian
Copy link
Contributor

Julusian commented Aug 3, 2020

I am happy to take over with my fork too

@aminya
Copy link
Collaborator

aminya commented Oct 23, 2020

@ericfreese Could you give us access? If we could transfer this repo to an organization, it would be easier to manage things.

@ericfreese
Copy link
Owner

Ok @aminya i invited you as a collaborator. Let me know if you need anything else

@aminya
Copy link
Collaborator

aminya commented Oct 24, 2020

Thank you! @ericfreese

First of all, I will merge this! 🎉

@aminya aminya merged commit ddedcee into ericfreese:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build using nodejs v12
4 participants