-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for node 12 #12
fix for node 12 #12
Conversation
Any chance we can merge this? The current package does not work and it is not useful anymore. |
There is a fork here https://github.com/julusian/node-freetype2 by @Julusian. Could you help marging this? |
@aminya I am not expecting for my fork to be merged in, partly as this library does not appear to be maintained anymore, and due to the large scope of my changes. The api should be mostly the same, but there are some differences and it is possible I didnt implement some bits yet too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this. It works.
I integrated this to the Atom package: ericfreese/font-viewer#23. You can see it in action.
@Julusian We can first start by this pull request and then we can merge your fork. |
@Protryon is the current maintainer of this package as of #10 (comment). If he doesn't respond soon, would you be interested in taking over @aminya? |
@ericfreese Sure! I will be happy to do so. |
@ericfreese it seems that the previous maintainer is not active anymore |
I am happy to take over with my fork too |
@ericfreese Could you give us access? If we could transfer this repo to an organization, it would be easier to manage things. |
Ok @aminya i invited you as a collaborator. Let me know if you need anything else |
Thank you! @ericfreese First of all, I will merge this! 🎉 |
Closes #11