R: Move the method to the EmployeeCollection class

ericgu · Mar 19, 2016 · 3a769df · 3a769df
1 parent 4ece63e
commit 3a769df
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/EmployeeCollection.cs b/EmployeeCollection.cs
@@ -15,5 +15,20 @@ public List<Employee> Items
         {
             get { return _employeeCollection; }
         }
+
+        public static void AddEmployeeIfMatch(EmployeeFilter employeeFilter, string name, int age, bool isSalaried,
+            EmployeeCollection employeeCollection, int id)
+        {
+            if (employeeFilter.Matches(name, age, isSalaried))
+            {
+                employeeCollection.Items.Add(new Employee
+                {
+                    Name = name,
+                    Id = id,
+                    Age = age,
+                    IsSalaried = isSalaried
+                });
+            }
+        }
     }
 }
diff --git a/Yucky.cs b/Yucky.cs
@@ -40,26 +40,11 @@ public static EmployeeCollection GetEmployees(EmployeeFilter employeeFilter, Fak
                     int age = reader.GetInt32(EmployeeAgeColumnIndex);
                     bool isSalaried = reader.GetBoolean(EmployeeIsSalariedColumnIndex);
 
-                    AddEmployeeIfMatch(employeeFilter, name, age, isSalaried, employeeCollection, id);
+                    EmployeeCollection.AddEmployeeIfMatch(employeeFilter, name, age, isSalaried, employeeCollection, id);
                 }
             }
 
             return employeeCollection;
         }
-
-        private static void AddEmployeeIfMatch(EmployeeFilter employeeFilter, string name, int age, bool isSalaried,
-            EmployeeCollection employeeCollection, int id)
-        {
-            if (employeeFilter.Matches(name, age, isSalaried))
-            {
-                employeeCollection.Items.Add(new Employee
-                {
-                    Name = name,
-                    Id = id,
-                    Age = age,
-                    IsSalaried = isSalaried
-                });
-            }
-        }
     }
 }