Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes with the sample nuget package #33

Merged
merged 2 commits into from
Dec 16, 2012
Merged

Some fixes with the sample nuget package #33

merged 2 commits into from
Dec 16, 2012

Conversation

tikrimi
Copy link
Contributor

@tikrimi tikrimi commented Dec 11, 2012

Removing "@using MvcApplication1" in _BootstrapLayout views. The referrence is not used, and causes an error if you use an other namespace than "MvcApplication1".

Adding ExampleLayouts views in the sample nuget package

@erichexter
Copy link
Owner

awesome.. I had that fixed locally but did not get a chance to push it..
thank!

Eric Hexter

blog | http://Hex.LosTechies.com
info | http://www.linkedin.com/in/erichexter

On Tue, Dec 11, 2012 at 9:01 AM, Christophe Bonnevault <
notifications@github.com> wrote:

Removing "@using https://github.com/using MvcApplication1" in
_BootstrapLayout views. The referrence is not used, and causes an error if
you use an other namespace than "MvcApplication1".

Adding ExampleLayouts views in the sample nuget package

You can merge this Pull Request by running:

git pull https://github.com/tikrimi/twitter.bootstrap.mvc master

Or view, comment on, or merge it at:

#33
Commit Summary

  • Some fixes on the sample nuget package to work properly with
    ExampleL…

File Changes

  • M src/Views/Shared/_BootstrapLayout.basic.cshtml (1)
  • M src/Views/Shared/_BootstrapLayout.cshtml (1)
  • M src/Views/Shared/_BootstrapLayout.empty.cshtml (1)
  • M src/Views/Shared/_BootstrapLayout.narrow.cshtml (1)
  • M src/twitter-bootstrap-mvc-sample.nuspec (1)

Patch Links

@tikrimi
Copy link
Contributor Author

tikrimi commented Dec 11, 2012

Sorry, I'm a beginner with GitHub. Next time I will do a branch to not have 2 commits that deal with different things in one issue.

erichexter added a commit that referenced this pull request Dec 16, 2012
Some fixes with the sample nuget package
@erichexter erichexter merged commit 565bda7 into erichexter:master Dec 16, 2012
@erichexter
Copy link
Owner

I went thru this last night.. I will remove my original layout and use the
basic one as the main layout going forward. There are some form styling in
the layouts, I think should be removed from the layouts and put into the
views that need them... login.

Eric Hexter

blog | http://Hex.LosTechies.com
info | http://www.linkedin.com/in/erichexter

On Tue, Dec 11, 2012 at 3:23 PM, Christophe Bonnevault <
notifications@github.com> wrote:

Sorry, I'm a beginner with GitHub. Next time I will do a branch to not
have 2 commits that deal with different things in one issue.


Reply to this email directly or view it on GitHubhttps://github.com//pull/33#issuecomment-11264793.

@erichexter
Copy link
Owner

I appreciate your pull request, will please submit this contributor agreement. http://sdrv.ms/13eMRXm this will help keep the project compliant with our open source license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants