-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Int64 doesn't handle lower bound properly #76
Comments
You're correct about precision. Your call to You're also correct that branch doesn't take into consideration that the negative half of a 64-bit integer is +1 larger than the positive half. |
Okay. That's fixed. I'm gonna push up a 3.1 which has a handful of bug fixes once Travis CI green lights me. Thanks for reporting them. Your issue made me curious: do you need something like |
Unless I'm misunderstanding, all 3 should return true?
It looks like it's triggering the
u > math.MaxInt64
branch.I imagine it might be something related to .compact being uint64, but here we care about int64, but I haven't dived in too deep.
I realised it might have something to do with the set precision - if i set precision high enough, then math.MinInt64+1 works correctly, but never math.MinInt64.
Is this intended behaviour?
The text was updated successfully, but these errors were encountered: