Fixed newer packages mistakenly considered as older #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a package had a pkgver containing `-rXX`, the number was ignored. Therefore, the program can wrongly consider a newer package as older.
ericm
approved these changes
Jun 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this prompt while using the program today.
After investigating the code, I realized that the number after the
.ris being ignored.With this exact setup (where
oldVersionandnewVersionare in the form of456.r4x-1), theoldVerandnewVerarrays becomes the same, and returns false.I made a simple fix for now, but it probably needs a deeper look. I couldn't find any reliant package version conventions online, and I am not sure how the program should behave if the
.rXXis being added or removed. For now, I just checked if it existed on both versions.